Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typescript to ignore example folder #96

Merged
merged 2 commits into from
Sep 28, 2019
Merged

fix: typescript to ignore example folder #96

merged 2 commits into from
Sep 28, 2019

Conversation

gorhom
Copy link
Contributor

@gorhom gorhom commented Sep 23, 2019

Hi @osdnk ,

i notice since my last PR #68, Typescript starts include Example folder to the compiled build which breaks the types for this library.

image

I have fixed this by only include src in the tsconfig.json.

Thanks

@gorhom gorhom changed the title fix: typescript to ignore example folder [WIP]: fix: typescript to ignore example folder Sep 23, 2019
@gorhom gorhom changed the title [WIP]: fix: typescript to ignore example folder fix: typescript to ignore example folder Sep 23, 2019
@osdnk osdnk merged commit 5446288 into osdnk:master Sep 28, 2019
@gorhom gorhom mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gorhom @osdnk