Skip to content

Conversation

@ryzokuken
Copy link
Member

@ryzokuken ryzokuken commented Oct 17, 2016

@ryzokuken
Copy link
Member Author

#25

@526avijitgupta
Copy link
Member

@ryzokuken I think there must be a way to download these packages through the command line itself.. rather than opening python REPL. Can you please use that instead!

@ryzokuken
Copy link
Member Author

Done. @526avijitgupta @yashmehrotra please review.

@yashmehrotra
Copy link
Member

@ryzokuken Please locally test your code before asking for code reviews

@ryzokuken
Copy link
Member Author

I did test install and test and they were working perfectly

@yashmehrotra
Copy link
Member

@ryzokuken make serve and make run won't work

@ryzokuken
Copy link
Member Author

I realize that. Please help me figure out an alternative... It feels counterproductive to write a make command for just running the server as it requires just a single command anyway. Do I drop make serve and make run for now?

@yashmehrotra
Copy link
Member

@ryzokuken
Copy link
Member Author

@yashmehrotra I'm sorry I couldn't quite get what you meant to say (I did get upto reading their Makefile though). I was thinking, should I make the python server run in the background for run and serve? That'd not show the server's logs or errors though. Maybe redirect the output of the server to a file that is .gitignored?

@yashmehrotra
Copy link
Member

Make a Procfile as specified in honcho and run nodejs and python simultaneously using make serve/make run

@ryzokuken
Copy link
Member Author

@yashmehrotra Could you please take on from here? The makefile stuff (saving PID in a temporary file on start and killing the process + deleting the temp file on stop) seems to be getting too complex.

@526avijitgupta
Copy link
Member

@yashmehrotra Are you going to work on this ?

@526avijitgupta
Copy link
Member

@ryzokuken @yashmehrotra Close this?

@ryzokuken
Copy link
Member Author

@526avijitgupta why? I think I know more now, I can take care of the Makefiles.

@526avijitgupta
Copy link
Member

@ryzokuken That works too

@yashmehrotra yashmehrotra removed their assignment Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants