Skip to content

feat: Обновление версии OVM до 1.5.0 и добавление поддержки osx-arm64 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025

Conversation

sfaqer
Copy link
Member

@sfaqer sfaqer commented Apr 20, 2025

  • Обновлена версия OVM в packagedef и ПараметрыПриложения.os до 1.5.0.
  • Обновлена версия платформы 1script до 1.9.2
  • Добавлена зависимость от cpuinfo версии 1.1.0.
  • В УстановщикOneScript.os добавлена поддержка определения типа дистрибутива для MacOS на архитектуре ARM (osx-arm64).

Summary by CodeRabbit

  • New Features
    • Improved platform and architecture detection for distribution selection, including support for MacOS ARM processors.
  • Chores
    • Updated application version to 1.4.0.
    • Increased minimum required environment version.
    • Added a new dependency on the cpuinfo package.

@sfaqer sfaqer requested a review from nixel2007 April 20, 2025 06:29
@sfaqer sfaqer marked this pull request as draft April 20, 2025 06:29
@nixel2007
Copy link
Member

@coderabbitai full review

Copy link

coderabbitai bot commented Apr 20, 2025

✅ Actions performed

Full review triggered.

Copy link

coderabbitai bot commented Apr 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes update the package version and environment requirements, introduce a new runtime dependency, and revise the application version string. The logic for determining the distribution type for installations has been refactored to use a new function that considers both platform and CPU architecture, with explicit support for ARM-based MacOS. The previous static mapping approach has been replaced with conditional logic, and the new function now raises an exception if the platform or architecture cannot be determined.

Changes

File(s) Change Summary
packagedef Updated package version to 1.4.0, increased environment version requirement, and added "cpuinfo" as a dependency.
src/core/Классы/ПараметрыПриложения.os Changed the return value of ВерсияПриложения() from "1.3.0" to "1.4.0".
src/core/Классы/УстановщикOneScript.os Replaced static mapping logic with a new function that determines distribution type based on platform and CPU architecture, including ARM support for MacOS. Renamed function and updated control flow.

Sequence Diagram(s)

sequenceDiagram
    participant Installer as УстановщикOneScript
    participant SystemInfo as СистемнаяИнформация
    participant CPUInfo as ИнформацияОПроцессоре

    Installer->>SystemInfo: ПолучитьТипПлатформы()
    Installer->>CPUInfo: ПолучитьАрхитектуру()
    alt Windows x86/x86_64
        Installer->>Installer: Вернуть "scd-win"
    else Linux x86/x86_64
        Installer->>Installer: Вернуть "scd-lin"
    else MacOS
        alt ARM/ARM64
            Installer->>Installer: Вернуть "osx-arm64"
        else
            Installer->>Installer: Вернуть "osx-x64"
        end
    else Unknown
        Installer->>Installer: Исключение "Не удалось определить ОС"
    end
Loading

Poem

A hop and a skip, our version’s anew,
With ARM on the Mac, we welcome the crew!
The package is fresher, dependencies set,
Now “cpuinfo” joins—our best update yet.
The installer’s much smarter, it knows what to do,
For every new platform, and architectures too!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nixel2007
Copy link
Member

@sfaqer а почему драфт?

@sfaqer
Copy link
Member Author

sfaqer commented Apr 20, 2025

@sfaqer а почему драфт?

Зареквестил тестов в чатике от маководов, жду.

@nixel2007 nixel2007 self-requested a review April 20, 2025 14:39
nixel2007 and others added 6 commits May 1, 2025 20:36
feat: Обновление версии OVM до 1.4.0 и добавление поддержки osx-arm64

- Обновлена версия OVM в packagedef и ПараметрыПриложения.os до 1.4.0.
- Обновлена версия платформы 1script до 1.9.2
- Добавлена зависимость от cpuinfo версии 1.1.0.
- В УстановщикOneScript.os добавлена поддержка определения типа дистрибутива для MacOS на архитектуре ARM (osx-arm64).
…ю о системе, препроцессор по видимому то-ли в 1.9 то-ли в моно не работает
@sfaqer sfaqer force-pushed the feature/macOS-arm branch from ab7faaf to f1a6f92 Compare May 2, 2025 01:15
@sfaqer sfaqer changed the title feat: Обновление версии OVM до 1.4.0 и добавление поддержки osx-arm64 feat: Обновление версии OVM до 1.5.0 и добавление поддержки osx-arm64 May 2, 2025
@sfaqer sfaqer requested a review from nixel2007 May 2, 2025 01:16
@sfaqer sfaqer marked this pull request as ready for review May 2, 2025 01:16
@nixel2007 nixel2007 merged commit 2d6d1e6 into oscript-library:master May 2, 2025
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants