This repository was archived by the owner on Nov 26, 2025. It is now read-only.
feat: basic process and thread #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure-stars
reviewed
Apr 7, 2025
api/src/imp/task/clone.rs
Outdated
| .init_new(FD_TABLE.copy_inner()); | ||
| } | ||
|
|
||
| if flags.contains(CloneFlags::CLONE_FS) { |
Collaborator
There was a problem hiding this comment.
Can we separate these operations into some functions, such as operations corresponding to clone_fs and clone_thread flags?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure how to do this best. Ideally we could reuse most of the code for clone3, but it's also possible to just forward clone to clone3 after implementing clone3.
Collaborator
There was a problem hiding this comment.
Linux just forward clone to clone3 after implementing clone3(see https://github.com/torvalds/linux/blob/c62f4b82d57155f35befb5c8bbae176614b87623/kernel/fork.c#L2953-L2989)
Co-authored-by: mivik <mivikq@gmail.com>
AsakuraMizu
changed the title
Azure-stars
reviewed
Apr 16, 2025
Azure-stars
reviewed
Apr 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by oscomp/arceos#30
Description
This PR introduces basic process management and thread support via
axprocess.The "basic" I mentioned includes two aspects:
getsidandsetpgid, but they are already implemented inaxprocessso we can later add these functions easily. Not adding them to keep this PR's simplicity.exit_groupandexecve.This PR also resolves #18 (comment).