Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Conversation

@AsakuraMizu
Copy link
Collaborator

@AsakuraMizu AsakuraMizu commented Mar 6, 2025

Temporarily using my own fork of flatten_objects, blocked by upstream: arceos-org/flatten_objects#2
The upstream has merged the PR but not yet released

Some functions using fd_table.count() have incorrect behaviours: they assume count to be maximum file descriptor.

To fix it, I have added an ids method on upstream FlattenObjects to retrive all open file descriptors to make copy_inner work properly. The other two use cases are redundant since Directory::from_fd already checks the validity of the file descriptor.

@AsakuraMizu AsakuraMizu marked this pull request as ready for review March 6, 2025 12:40
@Azure-stars
Copy link
Collaborator

Ok, and after the flatten_object release, please remember to update the dependencies.

@Azure-stars Azure-stars merged commit cbf30ba into oscomp:main Mar 7, 2025
24 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants