This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Fix fd table behaviours #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily using my own fork offlatten_objects, blocked by upstream: arceos-org/flatten_objects#2The upstream has merged the PR but not yet released
Some functions using
fd_table.count()have incorrect behaviours: they assumecountto be maximum file descriptor.To fix it, I have added an
idsmethod on upstreamFlattenObjectsto retrive all open file descriptors to makecopy_innerwork properly. The other two use cases are redundant sinceDirectory::from_fdalready checks the validity of the file descriptor.