Add appengine build tags for windows #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you run the local simulation of an appengine on windows, the mmap_windows.go variant is selected, which requiring an import of unsafe. Since unsafe is forbidden on appengine, we get an compile time error message looking like this: The Go application could not be built. (Executed command: C:\go_appengine\goroot\bin\go-app-builder.exe -app_base C:\goroot\src<redacted>\appentry -arch 6 -dynamic -goroot C:\go_appengine\goroot -nobuild_files ^^$ -unsafe -gopath C:\goroot\ -print_extras_hash main.go) 2016/12/05 11:39:12 go-app-builder: Failed parsing input: parser: bad import "unsafe" in github.com\oschwald\maxminddb-golang\decoder.go from GOPATH So we fix this by putting an explicit build tag which excludes appengine on windows there.
Contributor
Author
|
Hi @oschwald please take a look and integrate this oneliner soonish. It helps all people developing for appengine on their windows machines. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run the local simulation of an appengine on windows,
the mmap_windows.go variant is selected, which requiring an import of unsafe.
Since unsafe is forbidden on appengine, we get an compile time error message looking like this:
The Go application could not be built. (Executed command: C:\go_appengine\goroot\bin\go-app-builder.exe -app_base C:\goroot\src\appentry -arch 6 -dynamic -goroot C:\go_appengine\goroot -nobuild_files ^^$ -unsafe -gopath C:\goroot\ -print_extras_hash main.go) 2016/12/05 11:39:12 go-app-builder: Failed parsing input: parser: bad import "unsafe" in github.com\oschwald\maxminddb-golang\decoder.go from GOPATH
So we fix this by putting an explicit build tag which excludes appengine on windows there.