Skip to content

Call SyscallConn() instead of Fd() to use file's fd #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Call SyscallConn() instead of Fd() to use file's fd #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func Open(file string, options ...ReaderOption) (*Reader, error) {
return nil, errors.New("file too large")
}

data, err := mmap(int(mapFile.Fd()), size)
data, err := openMmap(mapFile, size)
if err != nil {
if errors.Is(err, errors.ErrUnsupported) {
data, err = openFallback(mapFile, size)
Expand All @@ -257,6 +257,21 @@ func Open(file string, options ...ReaderOption) (*Reader, error) {
return reader, nil
}

func openMmap(f *os.File, size int) (data []byte, err error) {
rawConn, err := f.SyscallConn()
if err != nil {
return nil, err
}

if cerr := rawConn.Control(func(fd uintptr) {
data, err = mmap(int(fd), size)
}); cerr != nil {
return nil, cerr
}

return data, err
}

func openFallback(f *os.File, size int) (data []byte, err error) {
data = make([]byte, size)
_, err = io.ReadFull(f, data)
Expand Down
Loading