Keep minimum weight edge when merging parallel boundary edges in conversion from UserGraph to MatchingGraph/SearchGraph #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erGraph boundary nodes results in parallel boundary edges. Fixes #81.
… behaviour of pm::UserGraph::to_matching_graph
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 337 337
=========================================
Hits 337 337 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from a pm::UserGraph to a pm::MatchingGraph or pm::SearchGraph, all boundary nodes in the pm::UserGraph are merged into one virtual boundary node. This can sometimes lead to parallel boundary edges during the conversion. Previously, when these parallel boundary edges arose, only the first-added boundary edge was kept, leading to issue #81. This PR fixes the issue by keeping only the minimum-weight parallel boundary edge, since this edge is guaranteed to be chosen over the others by blossom.
Fixes #81.