attempt to fix #175#176
Merged
oscarhiggott merged 3 commits intooscarhiggott:u/oscarhiggott/handle-boundary-edge-component-and-refactorfrom Sep 25, 2025
Merged
attempt to fix #175#176oscarhiggott merged 3 commits intooscarhiggott:u/oscarhiggott/handle-boundary-edge-component-and-refactorfrom
oscarhiggott merged 3 commits intooscarhiggott:u/oscarhiggott/handle-boundary-edge-component-and-refactorfrom
Conversation
…-with-correlations Fix correlated matching boundary component handling
noajshu
changed the title
Owner
oscarhiggott
changed the base branch from
master
to
u/oscarhiggott/handle-boundary-edge-component-and-refactor
oscarhiggott
merged commit 7fef178
into
oscarhiggott:u/oscarhiggott/handle-boundary-edge-component-and-refactor
34 of 35 checks passed
Owner
|
Thanks for this! I merged your new test into the fix in the branch of #171 |
oscarhiggott
added a commit
that referenced
this pull request
Sep 25, 2025
…nclude_correlations` (#171) * Add more exhaustive tests of correlations. Fix a bug where edge weight rewrites in the search graph weren't always undone. * handle boundary edge component properly (fixing issue #175) and refactor * Add argument to determine if components are included as edges. Fix choice to include components. * remove support for cp38-macosx_arm64 * Add test to check for correlated matching boundary component handling (#176) Co-authored-by: oscarhiggott <29460323+oscarhiggott@users.noreply.github.com> --------- Co-authored-by: Noah Shutty <noajshu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt to fix #175
@smadhuk does this LGTY?