Add routes to the cloud-controller-manager #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements routing functionality in the cloud controller manager by adding a Routes controller that manages pod network routes using BinaryLane VPC Route Entries. The changes enable automatic route creation and deletion for Kubernetes pods across VPC-connected nodes.
Changes:
- Added Routes controller implementation with Create/List/Delete route operations
- Implemented VPC creation and management in deployment scripts
- Added comprehensive test coverage for routes functionality
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/cloud/routes.go | New routes controller implementing cloudprovider.Routes interface |
| internal/cloud/routes_test.go | Test coverage for routes controller operations |
| internal/cloud/cloud.go | Updated to return routes controller and accept CIDR parameter |
| internal/cloud/instances.go | Modified to prioritize VPC private IPs for internal addresses |
| internal/cloud/cloud_test.go | Added VPC-related mock methods and helper function |
| internal/binarylane/vpcs.go | New VPC API client methods for getting and updating VPCs |
| internal/binarylane/servers.go | Added pagination support and ErrServerNotFound sentinel error |
| internal/binarylane/servers_test.go | Test coverage for server pagination |
| internal/binarylane/client.go | Simplified client initialization |
| cmd/binarylane-cloud-controller-manager/main.go | Updated to pass cluster CIDR to cloud provider |
| scripts/deploy-cluster.sh | Added VPC creation and server association |
| scripts/delete-cluster.sh | Added VPC cleanup |
| scripts/e2e-test.sh | Added VPC and routes validation tests |
| README.md | Updated to document Routes Controller |
| AGENTS.md | New file documenting code style and testing instructions |
| .github/workflows/test.yml | Removed deprecated codecov configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.