add argument check to G-set constructor #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `check` argument check th default value `true` - if `check` is `true` then test whether the given action function fits to the given `seeds` - set `check` to `false` in situations where the function is known to fit
lgoettgens
reviewed
Oct 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
=======================================
Coverage 84.59% 84.60%
=======================================
Files 640 640
Lines 85116 85117 +1
=======================================
+ Hits 72008 72009 +1
Misses 13108 13108
|
fingolfin
reviewed
Oct 30, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
fingolfin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkargument with default valuetruecheckistruethen test whether the given action function fits to the givenseedschecktofalsein situations where the function is known to fitresolves #367