avoid calling conductor

[ThomasBreuer]

Instead, call Hecke.force_coerce_cyclo(Kg, data(x), Val(false)), which finds out whether the conversion works.

[codecov]

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (24c8f63) to head (06796c3).
Report is 24 commits behind head on master.

Files with missing lines	Patch %	Lines
src/Rings/AbelianClosure.jl	70.58%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   84.59%   84.59%   -0.01%     
==========================================
  Files         631      631              
  Lines       84906    85061     +155     
==========================================
+ Hits        71830    71955     +125     
- Misses      13076    13106      +30     

Files with missing lines	Coverage Δ
src/Rings/AbelianClosure.jl	94.28% <70.58%> (-0.02%)	⬇️

... and 34 files with indirect coverage changes

[thofma]

Hm, if check == true and res === nothing, will this return nothing? Sorry, I am not good with logic.

[fingolfin]

This code is rather confusing to me as well. But so is the old code: it indeed also returns nothing when check is true and conductor(x) != 1 ?!

[fingolfin]

I guess what confuses me is that check apparently has a different meaning here than it has in e.g. our constructors. Since I don't know what the meaning of check is supposed to be here, I can't comment further.

Is it documented somewhere?

[ThomasBreuer]

@fingolfin See my comment below: The function in question is internal and not documented (as well as the functions called by it). I think we could change the meaning of check to that in other situations.

[thofma]

might be better if @fieker has a look

[ThomasBreuer]

Yes, the function _embedding returns nothing if the second argument suppresses the error, like Hecke.force_coerce_cyclo does.
(I admit that the meaning of check may be confusing; taking that _embedding is undocumented and used only in my code, we could change this.)

[thofma]

Sorry, I missed that this is an internal function. Then forget my question. But @fieker should check.