-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce snake case function incidence_matrix
#4245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4245 +/- ##
=======================================
Coverage 84.59% 84.59%
=======================================
Files 631 631
Lines 85064 85085 +21
=======================================
+ Hits 71960 71981 +21
Misses 13104 13104
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good in general, needs one run of the julia formatter.
But I think we should disallow the non-bool / non-0-1 matrix input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this again, we should keep the input in the book tests as they are to make sure it keeps working.
test/book/cornerstones/polyhedral-geometry/simple_polyhedral_fan.jlcon
Outdated
Show resolved
Hide resolved
test/book/specialized/bies-kastner-toric-geometry/chow_ring.jlcon
Outdated
Show resolved
Hide resolved
test/book/specialized/bies-kastner-toric-geometry/normal_fan_square.jlcon
Outdated
Show resolved
Hide resolved
test/book/specialized/bies-kastner-toric-geometry/starsubdivision.jlcon
Outdated
Show resolved
Hide resolved
test/book/specialized/bies-kastner-toric-geometry/starsubdivision.jlcon
Outdated
Show resolved
Hide resolved
* introduced incidence_matrix and added docs * replaced IncidenceMatrix with incidence_matrix in docstrings * replaced IncidenceMatrix with incidence_matrix in tests * added method incidence_matrix(::SubObjectIterator) * adjusted IncidenceMatrix to incidence_matrix in test/book * added tests for new methods of incidence_matrix * applied suggestions for incidence_matrix from github * formatted PolyhedralGeometry/helpers.jl * keep IncidenceMatrix call in booktests --------- Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
IncidenceMatrix
does not have snake case constructors. This PR fixes that, properly documents the available methods and adjusts existing (doc-)tests.Solves #4033