Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce snake case function incidence_matrix #4245

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Conversation

alexej-jordan
Copy link
Collaborator

IncidenceMatrix does not have snake case constructors. This PR fixes that, properly documents the available methods and adjusts existing (doc-)tests.

Solves #4033

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (eaa8972) to head (a156c84).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4245   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      631           
  Lines       85064    85085   +21     
=======================================
+ Hits        71960    71981   +21     
  Misses      13104    13104           
Files with missing lines Coverage Δ
...erimental/Schemes/src/ToricBlowups/constructors.jl 89.83% <ø> (ø)
...ricVarieties/AlgebraicCycles/special_attributes.jl 100.00% <ø> (ø)
...ometry/ToricVarieties/CohomologyClasses/methods.jl 61.53% <ø> (ø)
...oricVarieties/NormalToricVarieties/constructors.jl 100.00% <ø> (ø)
...lyhedralGeometry/PolyhedralComplex/constructors.jl 95.45% <ø> (ø)
...PolyhedralGeometry/PolyhedralComplex/properties.jl 86.27% <ø> (ø)
...ometry/PolyhedralComplex/standard_constructions.jl 100.00% <ø> (ø)
...c/PolyhedralGeometry/PolyhedralFan/constructors.jl 88.63% <ø> (ø)
src/PolyhedralGeometry/PolyhedralFan/properties.jl 98.33% <ø> (ø)
...hedralGeometry/SubdivisionOfPoints/constructors.jl 79.16% <ø> (ø)
... and 7 more

... and 3 files with indirect coverage changes

Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good in general, needs one run of the julia formatter.

But I think we should disallow the non-bool / non-0-1 matrix input.

test/PolyhedralGeometry/types.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/helpers.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/helpers.jl Outdated Show resolved Hide resolved
@joschmitt joschmitt linked an issue Oct 25, 2024 that may be closed by this pull request
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this again, we should keep the input in the book tests as they are to make sure it keeps working.

@alexej-jordan alexej-jordan marked this pull request as ready for review October 28, 2024 11:06
@benlorenz benlorenz merged commit 020e83a into master Oct 28, 2024
30 checks passed
@benlorenz benlorenz deleted the aj/incidence_matrix branch October 28, 2024 15:51
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Oct 30, 2024
* introduced incidence_matrix and added docs

* replaced IncidenceMatrix with incidence_matrix in docstrings

* replaced IncidenceMatrix with incidence_matrix in tests

* added method incidence_matrix(::SubObjectIterator)

* adjusted IncidenceMatrix to incidence_matrix in test/book

* added tests for new methods of incidence_matrix

* applied suggestions for incidence_matrix from github

* formatted PolyhedralGeometry/helpers.jl

* keep IncidenceMatrix call in booktests

---------

Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing snake case aliases for IncidenceMatrix
2 participants