Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideal saturation: Resolving old question found in code #4238

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Oct 23, 2024

No description provided.

@wdecker wdecker marked this pull request as draft October 23, 2024 15:39
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (ba9558f) to head (b648d6d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/mpoly-ideals.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4238   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      631           
  Lines       85028    85028           
=======================================
+ Hits        71928    71929    +1     
+ Misses      13100    13099    -1     
Files with missing lines Coverage Δ
src/Rings/mpoly-ideals.jl 93.87% <80.00%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

@wdecker wdecker marked this pull request as ready for review October 23, 2024 18:45
@jankoboehm jankoboehm merged commit 73c88fa into master Oct 24, 2024
30 checks passed
@jankoboehm jankoboehm deleted the Wolfram branch October 24, 2024 01:40
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Oct 30, 2024
…4238)

* Ideal saturation: Resolving old question found in code

* Improvement, backwards compatibility

* correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants