Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated printing for empty combinatorial objects #4236

Merged

Conversation

lgoettgens
Copy link
Member

Resolves #4229.

Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't expect that I will see these prints very often in my day-to-day life, so anything is fine for me :)

Anyway, this works (and seems what @JohnAAbbott wished for?), so approval from me.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (7b49bb4) to head (9327676).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...inatorics/EnumerativeCombinatorics/compositions.jl 60.00% 2 Missing ⚠️
...mbinatorics/EnumerativeCombinatorics/partitions.jl 60.00% 2 Missing ⚠️
...rics/EnumerativeCombinatorics/weak_compositions.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4236      +/-   ##
==========================================
- Coverage   84.58%   84.58%   -0.01%     
==========================================
  Files         631      631              
  Lines       85012    85024      +12     
==========================================
+ Hits        71911    71919       +8     
- Misses      13101    13105       +4     
Files with missing lines Coverage Δ
...inatorics/EnumerativeCombinatorics/compositions.jl 93.98% <60.00%> (-1.37%) ⬇️
...mbinatorics/EnumerativeCombinatorics/partitions.jl 96.42% <60.00%> (-0.52%) ⬇️
...rics/EnumerativeCombinatorics/weak_compositions.jl 90.76% <60.00%> (-2.68%) ⬇️

... and 1 file with indirect coverage changes

@fingolfin fingolfin merged commit ab11326 into oscar-system:master Oct 24, 2024
29 checks passed
@lgoettgens lgoettgens deleted the lg/show-empty-combinatorics branch October 24, 2024 09:41
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nice printing for empty partition
3 participants