Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc fix: remove extra 'we' in design_decisions.md #4199

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 13, 2024

This PR aims to remove extra 'we' in the designdecision.md documentation.

The extra 'we' is located in https://docs.oscar-system.org/stable/DeveloperDocumentation/design_decisions/#What-Do-We-Have.

Hopefully, this sounds good.

@Fe-r-oz Fe-r-oz changed the title doc fix: remove extra 'we' in design decisions doc fix: remove extra 'we' in design_decisions.md Oct 13, 2024
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lgoettgens lgoettgens added the documentation Improvements or additions to documentation label Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (da7acb0) to head (12c5079).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4199   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      631           
  Lines       84899    84899           
=======================================
  Hits        71824    71824           
  Misses      13075    13075           

@afkafkafk13 afkafkafk13 merged commit 534513f into oscar-system:master Oct 14, 2024
29 checks passed
@Fe-r-oz Fe-r-oz deleted the doc branch October 14, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants