Update exterior_algebra
#4093
Merged
Update exterior_algebra
#4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unify functions for coefficient field and ring (while still using singular in the former case) - use `@varnames_interface` - re-structure tests
lgoettgens
force-pushed
the
lg/exterior_algebra
branch
from
36c9957
to
e74b92e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
- Coverage 84.69% 84.69% -0.01%
==========================================
Files 614 614
Lines 83568 83568
==========================================
- Hits 70780 70776 -4
- Misses 12788 12792 +4
|
|
Can we merge this in the meantime, even though the implementation in #4097 seems superior? This PR contains some small improvements that @HechtiDerLachs could then use in the user-facing constructors in #4097 as well |
|
Could we decide on @lgoettgens question (merge or leave it out) at triage? |
|
@HechtiDerLachs is fine with this, no complaints in triage |
fingolfin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more details to the changes.
This does not change anything large, just unifies and cleans up a bit.