Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Add some missing ensure_artifact_installed to doctests #4055

Merged

Conversation

lgoettgens
Copy link
Member

that were forgotten in #3965, but now sometimes result in doctest failures, e.g. https://github.com/oscar-system/Oscar.jl/actions/runs/10614389904/job/29420203302?pr=4050#step:8:650

@lgoettgens lgoettgens added topic: FTheoryTools experimental Only changes experimental parts of the code labels Aug 29, 2024
@HereAround
Copy link
Member

Thank you for catching this @lgoettgens . Sorry about that!

@HereAround HereAround enabled auto-merge (rebase) August 29, 2024 13:28
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (66928b8) to head (44dcca4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4055   +/-   ##
=======================================
  Coverage   84.66%   84.67%           
=======================================
  Files         600      600           
  Lines       82610    82610           
=======================================
+ Hits        69944    69946    +2     
+ Misses      12666    12664    -2     
Files with missing lines Coverage Δ
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 100.00% <ø> (ø)
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 40.00% <ø> (ø)
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@HereAround HereAround merged commit 3001f2d into oscar-system:master Aug 29, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/ensure_artifact_installed branch August 29, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants