-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ToricVarieties] Overhaul equality of normal toric varieties #3946
Merged
fingolfin
merged 1 commit into
oscar-system:master
from
HereAround:FixEqualityOfToricVarieties
Jul 24, 2024
Merged
[ToricVarieties] Overhaul equality of normal toric varieties #3946
fingolfin
merged 1 commit into
oscar-system:master
from
HereAround:FixEqualityOfToricVarieties
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
5 times, most recently
from
July 16, 2024 20:57
3691ae8
to
7ba01cf
Compare
lgoettgens
reviewed
Jul 16, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
lgoettgens
reviewed
Jul 16, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
from
July 16, 2024 21:22
7ba01cf
to
538d039
Compare
HereAround
changed the title
[ToricVarieites] Overhaul equality of normal toric varieties
[ToricVarieties] Overhaul equality of normal toric varieties
Jul 16, 2024
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
2 times, most recently
from
July 17, 2024 07:21
82432b3
to
e94adef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3946 +/- ##
==========================================
+ Coverage 83.98% 84.01% +0.02%
==========================================
Files 592 592
Lines 81635 81679 +44
==========================================
+ Hits 68562 68620 +58
+ Misses 13073 13059 -14
|
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
from
July 17, 2024 08:24
e94adef
to
b9d47e7
Compare
lgoettgens
reviewed
Jul 17, 2024
lgoettgens
reviewed
Jul 17, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
fingolfin
reviewed
Jul 17, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
lgoettgens
reviewed
Jul 17, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
6 times, most recently
from
July 17, 2024 13:19
4db48bf
to
33c8d48
Compare
lkastner
reviewed
Jul 17, 2024
docs/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties.md
Outdated
Show resolved
Hide resolved
lkastner
reviewed
Jul 17, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/constructors.jl
Outdated
Show resolved
Hide resolved
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
from
July 18, 2024 08:38
33c8d48
to
9dcc4eb
Compare
HereAround
force-pushed
the
FixEqualityOfToricVarieties
branch
from
July 18, 2024 09:23
9dcc4eb
to
2f52348
Compare
lkastner
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #3934 as follows:
==
method: Return true if===
is true and otherwise raise an error.slow_equal
. I have not exported this method (exports are hard to revert, we do not want anybody to use this method unless they really, really want to etc.). Still, the method is documented.==
of two toric varieties was used in a number of places. It seemed reasonable to change some of them to===
.