Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToricVarieties] Overhaul equality of normal toric varieties #3946

Merged

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jul 16, 2024

This PR aims to close #3934 as follows:

  • Overwrite the == method: Return true if === is true and otherwise raise an error.
  • Add documentation which explains why this computation is very demanding.
  • Add a (stupid) (as in not very performant) equality method slow_equal. I have not exported this method (exports are hard to revert, we do not want anybody to use this method unless they really, really want to etc.). Still, the method is documented.
  • Throughout OSCAR, == of two toric varieties was used in a number of places. It seemed reasonable to change some of them to ===.

@HereAround HereAround marked this pull request as draft July 16, 2024 19:55
@HereAround HereAround force-pushed the FixEqualityOfToricVarieties branch 5 times, most recently from 3691ae8 to 7ba01cf Compare July 16, 2024 20:57
@HereAround HereAround changed the title [ToricVarieites] Overhaul equality of normal toric varieties [ToricVarieties] Overhaul equality of normal toric varieties Jul 16, 2024
@HereAround HereAround force-pushed the FixEqualityOfToricVarieties branch 2 times, most recently from 82432b3 to e94adef Compare July 17, 2024 07:21
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (efd6412) to head (2f52348).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3946      +/-   ##
==========================================
+ Coverage   83.98%   84.01%   +0.02%     
==========================================
  Files         592      592              
  Lines       81635    81679      +44     
==========================================
+ Hits        68562    68620      +58     
+ Misses      13073    13059      -14     
Files Coverage Δ
experimental/Schemes/src/IdealSheaves.jl 78.71% <100.00%> (+0.03%) ⬆️
...oricVarieties/NormalToricVarieties/constructors.jl 100.00% <100.00%> (ø)
...ebraicGeometry/ToricVarieties/Proj/constructors.jl 92.72% <100.00%> (ø)
...etry/ToricVarieties/ToricMorphisms/constructors.jl 67.85% <100.00%> (ø)

... and 8 files with indirect coverage changes

@HereAround HereAround force-pushed the FixEqualityOfToricVarieties branch 6 times, most recently from 4db48bf to 33c8d48 Compare July 17, 2024 13:19
@HereAround HereAround marked this pull request as ready for review July 18, 2024 10:17
@HereAround HereAround requested a review from lkastner July 18, 2024 10:48
@fingolfin fingolfin merged commit d94eeca into oscar-system:master Jul 24, 2024
29 checks passed
@HereAround HereAround deleted the FixEqualityOfToricVarieties branch July 24, 2024 21:54
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Equality (in the sense of telling identically the same - NOT isomorphic) of toric varieties malfunctions
5 participants