-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] Overhaul Serialization #3932
[FTheoryTools] Overhaul Serialization #3932
Conversation
168338d
to
0291fde
Compare
cb8c1f6
to
9cd6d27
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3932 +/- ##
=======================================
Coverage 84.07% 84.08%
=======================================
Files 592 592
Lines 81758 81722 -36
=======================================
- Hits 68739 68713 -26
+ Misses 13019 13009 -10
|
7e31ff8
to
7556ab6
Compare
7556ab6
to
caf4251
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and all of the tests passed.
Then I let @antonydellavecchia make the final call. Would like to know if this is ok/acceptable as long as the OSCAR serialization standards are concerned. @antonydellavecchia, if/once you are happy, please consider merging. |
[I initially hoped to push this so that some of the JSON-files - that currently specify models - can be replaced by their mardi counterparts. This is not possible. Some of the data associated to the models cannot yet be serialized. For instance Lie algebras. I have not checked if there are other data types that we use and lack serialization (for instance graphs, as used for the QSMs. So I postpone this for now.]
cc @antonydellavecchia @apturner @emikelsons