Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test coverage and fixes #3855

Merged
merged 4 commits into from
Jun 12, 2024
Merged

More test coverage and fixes #3855

merged 4 commits into from
Jun 12, 2024

Conversation

simonbrandhorst
Copy link
Collaborator

@simonbrandhorst simonbrandhorst commented Jun 12, 2024

No description provided.

@simonbrandhorst simonbrandhorst changed the title More test coverage borcherds method More test coverage and fixes Jun 12, 2024
@simonbrandhorst
Copy link
Collaborator Author

@afkafkafk13 please merge

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (955d1a8) to head (a4236fc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
+ Coverage   81.79%   81.84%   +0.04%     
==========================================
  Files         580      580              
  Lines       79856    79858       +2     
==========================================
+ Hits        65322    65361      +39     
+ Misses      14534    14497      -37     
Files Coverage Δ
...braicGeometry/RationalPoint/AffineRationalPoint.jl 90.51% <100.00%> (+11.20%) ⬆️
src/AlgebraicGeometry/RationalPoint/PointSet.jl 80.00% <100.00%> (+16.00%) ⬆️
src/AlgebraicGeometry/Surfaces/K3Auto.jl 85.44% <100.00%> (+1.45%) ⬆️
...cGeometry/RationalPoint/ProjectiveRationalPoint.jl 78.52% <66.66%> (+2.01%) ⬆️

@afkafkafk13
Copy link
Collaborator

@afkafkafk13 please merge

@simonbrandhorst : Booktests fail. Please have a look at it: something is creating huge amounts of output there.

@benlorenz
Copy link
Member

@afkafkafk13 please merge

@simonbrandhorst : Booktests fail. Please have a look at it: something is creating huge amounts of output there.

The booktest failure looks like #3633, which might get fixed with some upcoming new GAP builds. I have restarted the job.

@afkafkafk13
Copy link
Collaborator

@afkafkafk13 please merge

@simonbrandhorst : Booktests fail. Please have a look at it: something is creating huge amounts of output there.

The booktest failure looks like #3633, which might get fixed with some upcoming new GAP builds. I have restarted the job.

Thank you for the hint. Then this has to wait until the bug is fixed as the failing test is blocking.

@thofma thofma merged commit e433715 into master Jun 12, 2024
30 checks passed
@thofma thofma deleted the sb/tests_k3_auto branch June 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants