Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 1.0.0 #3473

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Set version to 1.0.0 #3473

merged 1 commit into from
Mar 1, 2024

Conversation

benlorenz
Copy link
Member

No description provided.

@fingolfin
Copy link
Member

Oh, so are we doing this now? I thought the plan was to wait for this a bit longer to give us time past-book to improve the manual etc., so that we avoid potentially leaving a bad impression by having a 1.0 release with some major gaps (and things like "TODO: add this in") in the manual.

Not that I feel strong either way, I just don't see the point of having this now?

@fingolfin
Copy link
Member

(I don't mean to sound too negative, sorry -- I have no serious objections to this, I just feel confused, seems I misunderstood something)

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #3473 (a59c395) into release-1.0 (0eb303b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.0    #3473   +/-   ##
============================================
  Coverage        81.85%   81.85%           
============================================
  Files              563      563           
  Lines            75517    75517           
============================================
  Hits             61813    61813           
  Misses           13704    13704           

@benlorenz
Copy link
Member Author

benlorenz commented Mar 1, 2024

Oh, so are we doing this now? I thought the plan was to wait for this a bit longer to give us time past-book to improve the manual etc., so that we avoid potentially leaving a bad impression by having a 1.0 release with some major gaps (and things like "TODO: add this in") in the manual.

Not that I feel strong either way, I just don't see the point of having this now?

We discussed this a bit in the last meetings and the consensus was that we want to have a released version now (strictly speaking it should have been two days ago) that corresponds exactly to the code examples from the book.

But after that we can keep backporting changes for the manual and maybe tiny bugfixes to do a 1.0.1 or 1.0.2 release before May. That version should then show up for the docs of 1.0. (For julia you can also go to the 1.9 docs and get the 1.9.4 version)

@benlorenz benlorenz marked this pull request as ready for review March 1, 2024 11:22
@benlorenz benlorenz merged commit a148cee into release-1.0 Mar 1, 2024
27 checks passed
@benlorenz benlorenz deleted the bl/rel10 branch March 1, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants