Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to name printing changes in AA #3327

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Feb 7, 2024

Refactors everything about name printing to only use the interface discussed in Nemocas/AbstractAlgebra.jl#1594 (and no longer any internals).

This PR does not touch anything around Schemes, this will be postponed to the future since this is a bit more entangled.

No output is changed by this, it is a pure rewrite to use the correct interface without any semantical changes.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #3327 (d261ea1) into master (4876a85) will increase coverage by 0.00%.
Report is 12 commits behind head on master.
The diff coverage is 75.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3327   +/-   ##
=======================================
  Coverage   81.82%   81.82%           
=======================================
  Files         556      556           
  Lines       74338    74322   -16     
=======================================
- Hits        60824    60812   -12     
+ Misses      13514    13510    -4     
Files Coverage Δ
...tal/DoubleAndHyperComplexes/src/Objects/Methods.jl 89.40% <100.00%> (+0.56%) ⬆️
src/Modules/UngradedModules/FreeMod.jl 84.00% <100.00%> (-0.62%) ⬇️
src/Modules/UngradedModules/Presentation.jl 93.75% <100.00%> (ø)
src/Rings/mpoly-graded.jl 89.28% <80.00%> (ø)
src/Modules/ModulesGraded.jl 78.65% <0.00%> (ø)
src/Modules/UngradedModules/FreeResolutions.jl 89.12% <80.95%> (+0.54%) ⬆️
src/Modules/FreeModules-graded.jl 0.00% <0.00%> (ø)

@lgoettgens lgoettgens marked this pull request as ready for review February 7, 2024 13:12
@lgoettgens
Copy link
Member Author

Bump. Can we get this merged?

@benlorenz benlorenz merged commit 26ef8ea into oscar-system:master Feb 14, 2024
23 checks passed
@lgoettgens lgoettgens deleted the lg/name-showing branch February 14, 2024 07:49
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants