add support to adjoin many elements #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3294 +/- ##
==========================================
- Coverage 81.68% 81.60% -0.09%
==========================================
Files 546 546
Lines 73054 73463 +409
==========================================
+ Hits 59671 59946 +275
- Misses 13383 13517 +134
|
fingolfin
reviewed
Feb 1, 2024
experimental/GModule/Misc.jl
Outdated
| @@ -34,6 +68,7 @@ function Hecke.number_field(::QQField, a::qqbar; cached::Bool = false) | |||
| end | |||
|
|
|||
| Base.getindex(::QQField, a::qqbar) = number_field(QQ, a) | |||
| Base.getindex(::QQField, a::Vector{qqbar}) = number_field(QQ, a) | |||
There was a problem hiding this comment.
maybe also
Suggested change
| Base.getindex(::QQField, a::Vector{qqbar}) = number_field(QQ, a) | |
| Base.getindex(::QQField, a::Vector{qqbar}) = number_field(QQ, a) | |
| Base.getindex(::QQField, a::qbar, as::qqbar...) = number_field(QQ, [a, as...]) |
for interactive use: QQ[s,c]
fingolfin
approved these changes
Feb 1, 2024
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly more draft...
allows to do
rt = [a,b,c] of type Vector{qqbar}
QQ[rt]
should help to transposrt matrices...