feat: adjust for upcoming indexing changes #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3276 +/- ##
=======================================
Coverage 81.62% 81.63%
=======================================
Files 546 546
Lines 73282 73296 +14
=======================================
+ Hits 59820 59833 +13
- Misses 13462 13463 +1
|
fingolfin
reviewed
Jan 31, 2024
| @@ -259,7 +259,7 @@ function _construct_literature_model_over_concrete_base(model_dict::Dict{String, | |||
|
|
|||
| # Find divisor classes of the internal model sections | |||
| auxiliary_base_grading = matrix(ZZ, transpose(hcat([[eval_poly(weight, ZZ) for weight in vec] for vec in model_dict["model_data"]["auxiliary_base_grading"]]...))) | |||
| auxiliary_base_grading = vcat([[Int(k) for k in auxiliary_base_grading[i,:]] for i in 1:nrows(auxiliary_base_grading)]...) | |||
| auxiliary_base_grading = vcat([[Int(k) for k in auxiliary_base_grading[i:i,:]] for i in 1:nrows(auxiliary_base_grading)]...) | |||
There was a problem hiding this comment.
Not an objection, just trying to understand: presumably the old and new code will behave differently in the future? What will the difference be?
For Julia matrices, the difference is whether a vector or a matrix is returned. But we don't have dedicated vector objects, have we? Or is the plan to add them? (Ah, perhaps for a sparse matrix we'd be returning SRow versus SMat ?)
There was a problem hiding this comment.
Yes. It will just be a Vector (see the Linear algebra roadmap), so that the dimension of the indices now correspond to the dimension to the output (as for julia arrays).
- Nowadays we have more support for
Matrix * Vectorandsolve(::Matrix, ::Vector)and things like that, which we did not have 5 years ago. So back then we avoidedVectorat all costs. - At the moment, it is cumbersome to get rows/columns as
Vector. With the "new" indexing, it is easy: Just do[i, :]. To get it as a matrix, just do[[i], :]or[i:i, :].
lgoettgens
approved these changes
Jan 31, 2024
src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/standard_constructions.jl
Outdated
Show resolved
Hide resolved
joschmitt
approved these changes
Jan 31, 2024
…dard_constructions.jl Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
This was referenced Feb 4, 2024
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes here, but it will allow us to eventually clean up some of the indexing for matrices.