Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt unicode printing of exterior powers of Lie algebra modules #3270

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

lgoettgens
Copy link
Member

Resolves the Lie algebra part of #3257.

(v_1∧v_3) ⊗ (v_2∧v_3)
(v_2∧v_3) ⊗ (v_1∧v_2)
(v_2∧v_3) ⊗ (v_1∧v_3)
(v_2∧v_3) ⊗ (v_2∧v_3)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While adding some doctests for this and similar cases, I noticed that \otimes is used as well. Do you have a suggestion for some non-unicode way to print these? @fingolfin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, no great solution from me. I've seen all kinds of hacks for this like (x), x; #; ... oh and also /\ instead of ^ for . So e.g.

  • (v_2^v_3) (x) (v_2^v_3)
  • (v_2^v_3) x (v_2^v_3)
  • (v_2/\v_3) (x) (v_2/\v_3)
  • (v_2/\v_3) x (v_2/\v_3)

Frankly none of these are great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now use (x) for the time being.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #3270 (7e5980f) into master (2e151d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3270   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files         546      546           
  Lines       73283    73285    +2     
=======================================
+ Hits        59824    59828    +4     
+ Misses      13459    13457    -2     
Files Coverage Δ
experimental/LieAlgebras/src/LieAlgebraModule.jl 90.65% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@fingolfin fingolfin merged commit b2455d0 into oscar-system:master Jan 31, 2024
23 checks passed
@lgoettgens lgoettgens deleted the lg/unicode-lie branch February 7, 2024 13:27
ooinaruhugh pushed a commit to ooinaruhugh/Oscar.jl that referenced this pull request Feb 15, 2024
…ar-system#3270)

* Adapt unicode printing of exterior powers
* Add some doctests
* Adapt tensor printing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants