Remove obsolete getindex methods for accessing generators
#3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/getindex
branch
from
4570264
to
cff0c7c
Compare
lgoettgens
force-pushed
the
mh/getindex
branch
from
15c4df2
to
c42fa25
Compare
lgoettgens
approved these changes
Jan 29, 2024
AA defines this generically
fingolfin
force-pushed
the
mh/getindex
branch
from
c42fa25
to
4a90e9a
Compare
lgoettgens
reviewed
Jan 29, 2024
src/Rings/PBWAlgebra.jl
Outdated
| @@ -20,7 +20,7 @@ mutable struct PBWAlgElem{T, S} <: NCRingElem | |||
| sdata::Singular.spluralg{S} | |||
| end | |||
|
|
|||
| mutable struct PBWAlgIdeal{D, T, S} | |||
| mutable struct PBWAlgIdeal{D, T, S} <: Ideal{PBWAlgIdeal{T, S}} | |||
There was a problem hiding this comment.
Should this be recursive? I expected something along the lines of Ideal{PBWAlgebra{...}}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3260 +/- ##
==========================================
- Coverage 81.65% 81.65% -0.01%
==========================================
Files 546 546
Lines 73102 73148 +46
==========================================
+ Hits 59692 59727 +35
- Misses 13410 13421 +11
|
fingolfin
commented
Jan 30, 2024
Co-authored-by: Max Horn <max@quendi.de>
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
…stem#3260) * Avoid R[0] * Add some missing supertypes * Remove obsolete getindex methods for accessing generators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AA defines this generically, with one exception
R[0]is not defined, yet some code uses it to representzero(R). Such code should be changed to useR(0)orzero(R).I fixed two of these, but there might be more, we'll see.