-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Documenter.jl
to v1.0
#2927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
==========================================
- Coverage 80.40% 80.39% -0.01%
==========================================
Files 461 461
Lines 65589 65589
==========================================
- Hits 52734 52733 -1
- Misses 12855 12856 +1
|
The warning
will get resolved by thofma/Hecke.jl#1246. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview looks good, I did not check all the pages but I haven't found any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lgoettgens . Similar to @benlorenz , I checked the preview and could not find issues. I believe this is thus ready to go.
See title.
Documenter.jl v1.0 has a lot more features for cross-referencing between docs of different packages, that can be very useful for our copy-pasting hack. But I skipped dealing with that / deactivated it for now and leave the fix to #588.
Preview: https://docs.oscar-system.org/previews/PR2927/