Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Documenter.jl to v1.0 #2927

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Bump Documenter.jl to v1.0 #2927

merged 6 commits into from
Oct 18, 2023

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Oct 17, 2023

See title.

Documenter.jl v1.0 has a lot more features for cross-referencing between docs of different packages, that can be very useful for our copy-pasting hack. But I skipped dealing with that / deactivated it for now and leave the fix to #588.

Preview: https://docs.oscar-system.org/previews/PR2927/

@lgoettgens lgoettgens added the documentation Improvements or additions to documentation label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2927 (1a746ee) into master (fe5db32) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2927      +/-   ##
==========================================
- Coverage   80.40%   80.39%   -0.01%     
==========================================
  Files         461      461              
  Lines       65589    65589              
==========================================
- Hits        52734    52733       -1     
- Misses      12855    12856       +1     
Files Coverage Δ
...edralGeometry/Polyhedron/standard_constructions.jl 95.65% <ø> (ø)
src/utils/docs.jl 1.33% <0.00%> (ø)

... and 1 file with indirect coverage changes

@lgoettgens
Copy link
Member Author

The warning

┌ Warning: Unexpected Julia interpolation of type Symbol in the Markdown.
│   value = :k_
└ @ Documenter.HTMLWriter ~/.julia/packages/Documenter/cxHBW/src/html/HTMLWriter.jl:2215

will get resolved by thofma/Hecke.jl#1246.

@lgoettgens lgoettgens marked this pull request as ready for review October 17, 2023 12:02
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview looks good, I did not check all the pages but I haven't found any issues.

Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lgoettgens . Similar to @benlorenz , I checked the preview and could not find issues. I believe this is thus ready to go.

@HereAround HereAround merged commit 65c9c93 into master Oct 18, 2023
23 of 29 checks passed
@HereAround HereAround deleted the lg/documenter branch October 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants