Skip to content

Commit

Permalink
asd
Browse files Browse the repository at this point in the history
  • Loading branch information
thofma committed Jul 20, 2024
1 parent 16a4b99 commit bdab2ad
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion experimental/SymmetricIntersections/src/representations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ function _has_pfr(G::Oscar.GAPGroup, dim::Int)
G_gap = G.X
f_gap = GG.EpimorphismSchurCover(G_gap)::GapObj
H_gap = GG.Source(f_gap)::GapObj
n, p = is_power(GG.Size(H_gap))::Tuple{Int, Int}
n, p = is_perfect_power_with_data(GG.Size(H_gap))::Tuple{Int, Int}
if is_prime(p)
fff_gap = GG.EpimorphismPGroup(H_gap, p)::GapObj
E_gap = fff_gap(H_gap)::GapObj
Expand Down
4 changes: 2 additions & 2 deletions src/Groups/matrices/stuff_field_gen.jl
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@

# changes the base ring of a polynomial ring into fqPolyRepFieldElem
function _change_type(f::PolyRingElem{T}) where T <: FinFieldElem
e,p = is_power(order(base_ring(f)))
e,p = is_perfect_power_with_data(order(base_ring(f)))

Check warning on line 11 in src/Groups/matrices/stuff_field_gen.jl

View check run for this annotation

Codecov / codecov/patch

src/Groups/matrices/stuff_field_gen.jl#L11

Added line #L11 was not covered by tests
F = GF(Int(p),Int(e))
t = polynomial_ring(F,"t"; cached=false)[2]
return sum([t^i*F(lift(coeff(f,i))) for i in 0:degree(f)])
end

function _change_type(f::PolyRingElem{<: FqFieldElem})
e,p = is_power(order(base_ring(f)))
e,p = is_perfect_power_with_data(order(base_ring(f)))
F = GF(Int(p),Int(e))
t = polynomial_ring(F,"t"; cached=false)[2]
return sum([t^i*F(lift(ZZ, coeff(f,i))) for i in 0:degree(f)])
Expand Down
4 changes: 2 additions & 2 deletions test/Groups/subgroups_and_cosets.jl
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,12 @@ end
Lo = [order(l) for l in L]
@test length(Lo)==length(factor(order(G)))
@test prod(Lo) == order(G)
@test [is_prime(is_power(l)[2]) for l in Lo] == [1 for i in 1:length(L)]
@test [is_prime(is_perfect_power_with_data(l)[2]) for l in Lo] == [1 for i in 1:length(L)]
L = complement_system(G)
Lo = [index(G,l) for l in L]
@test length(Lo)==length(factor(order(G)))
@test prod(Lo) == order(G)
@test [is_prime(is_power(l)[2]) for l in Lo] == [1 for i in 1:length(L)]
@test [is_prime(is_perfect_power_with_data(l)[2]) for l in Lo] == [1 for i in 1:length(L)]

L = hall_system(symmetric_group(4))
@test is_subset(L[1], symmetric_group(4))
Expand Down

0 comments on commit bdab2ad

Please sign in to comment.