Use algebraic_closure(QQ) instead of QQBar (#3954)

oscar-system · Jul 19, 2024 · 9479dae · 9479dae
1 parent 3e7f901
commit 9479dae
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/experimental/QuadFormAndIsom/src/lattices_with_isometry.jl b/experimental/QuadFormAndIsom/src/lattices_with_isometry.jl
@@ -1837,7 +1837,7 @@ function signatures(Lf::ZZLatWithIsom)
   f = isometry(Lf)
   n = order_of_isometry(Lf)
   C = CalciumField()
-  eig = eigenvalues(QQBar, f)
+  eig = eigenvalues(algebraic_closure(QQ), f)
   lambda = C(eig[1])
   Sq = Int[i for i in 1:div(n,2) if gcd(i,n) == 1]
   D = Dict{Integer, Tuple{Int, Int}}()

diff --git a/src/AlgebraicGeometry/Surfaces/K3Auto.jl b/src/AlgebraicGeometry/Surfaces/K3Auto.jl
@@ -1931,7 +1931,7 @@ function ample_class(S::ZZLat)
     else
       rv = (r*gram_matrix(S)*transpose(v))[1,1]
       p = x^2*vsq + 2*x*rv + rsq
-      rp = roots(CalciumQQBar, p)
+      rp = roots(algebraic_closure(QQ), p)
       a = rp[1]
       b = rp[2]
       if a > b

diff --git a/src/imports.jl b/src/imports.jl
@@ -196,8 +196,7 @@ import Hecke:
   IntegerUnion,
   MapHeader,
   multiplicative_jordan_decomposition,
-  primitive_element,
-  QQBar
+  primitive_element
 
 # temporary workaround, see https://github.com/thofma/Hecke.jl/pull/1224
 if !isdefined(Hecke, :torsion_free_rank)