Make _iso_oscar_gap(::AbstractLieAlgeba) way more efficient

oscar-system · Oct 22, 2024 · 241ac1f · 241ac1f
1 parent 88b734c
commit 241ac1f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/experimental/LieAlgebras/src/iso_oscar_gap.jl b/experimental/LieAlgebras/src/iso_oscar_gap.jl
@@ -41,10 +41,10 @@ function _iso_oscar_gap(LO::AbstractLieAlgebra; set_attributes::Bool=true)
     [
       [
         begin
-          pairs = filter(pair -> !iszero(last(pair)), collect(enumerate(_matrix(xi * xj))))
-          (map(first, pairs), GAP.Obj[coeffs_iso(c) for c in map(last, pairs)])
-        end for xj in basis(LO)
-      ] for xi in basis(LO)
+          pairs = collect(LO.struct_consts[i, j])
+          (first.(pairs), GAP.Obj[coeffs_iso(c) for c in last.(pairs)])
+        end for j in 1:dim(LO)
+      ] for i in 1:dim(LO)
     ]
     -1
     coeffs_iso(zero(coefficient_ring(LO)))