Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: allow GAP_pkg_juliainterface_jll 0.800.202 #869

Merged
merged 1 commit into from
May 10, 2023

Conversation

benlorenz
Copy link
Member

Not sure if this is correct, or why the previous 0.800.202 was not allowed so far.
But something like this is needed to allow the new rebuild for julia nightly, maybe the restriction can be loosened up a bit?

The nightly build will probably still fail as the new releases are not in the julia registry yet.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #869 (0d7bf33) into master (9de7045) will increase coverage by 0.30%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   75.34%   75.64%   +0.30%     
==========================================
  Files          50       51       +1     
  Lines        4104     4118      +14     
==========================================
+ Hits         3092     3115      +23     
+ Misses       1012     1003       -9     

see 6 files with indirect coverage changes

@benlorenz
Copy link
Member Author

GAP now loads on julia nightly but the tests fail with some replcompletions errors. (Probably to be fixed by #866 ?)

@fingolfin fingolfin closed this May 10, 2023
@fingolfin fingolfin reopened this May 10, 2023
@@ -20,7 +20,7 @@ Scratch = "6c6a2e73-6563-6170-7368-637461726353"
[compat]
GAP_jll = "~400.1200.101"
GAP_lib_jll = "~400.1201.100"
GAP_pkg_juliainterface_jll = "=0.800.201"
GAP_pkg_juliainterface_jll = "=0.800.201, =0.800.202"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I've been so strict here is that we want to make sure we really use the exact same C code in the JLL which matches the one used in GAP_jll. However, for quick fixes like this, that's a nasty impediment. So, we should loosen it and just be very careful about how we change versions for GAP_pkg_juliainterface_jll.

However, I'd like to do this carefully, so just to get a fix out ASAP, I'll merge this PR as-is and then follow up with a looser version (and maybe more) later. I'll open an issue to remind me about that.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fingolfin fingolfin marked this pull request as ready for review May 10, 2023 07:01
@fingolfin fingolfin merged commit 7b8838d into master May 10, 2023
@fingolfin fingolfin deleted the bl/juliainterfacebump branch May 10, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants