do not mention fmpz in the JuliaInterface manual
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
- Coverage 81.78% 75.49% -6.30%
==========================================
Files 49 51 +2
Lines 3679 4101 +422
==========================================
+ Hits 3009 3096 +87
- Misses 670 1005 +335
|
fingolfin
reviewed
Feb 22, 2023
| #! is handled in the context of the <Package>Oscar</Package> system, | ||
| #! which uses both &GAP; and <Package>Nemo.jl</Package>, | ||
| #! but <Package>JuliaInterface</Package> does not deal with it. | ||
| #! For example, the &Julia; package <Package>Oscar.jl</Package> defines |
There was a problem hiding this comment.
Suggested change
| #! For example, the &Julia; package <Package>Oscar.jl</Package> defines | |
| #! For example, the &Julia; package <Package>Oscar.jl</Package> provides |
Then it also encompasses fmpz
fingolfin
approved these changes
Feb 23, 2023
pkg/JuliaInterface/gap/calls.gi
Outdated
| @@ -5,7 +5,7 @@ BindGlobal("_JL_Dict_Any", JuliaEvalString("Dict{Symbol,Any}")); | |||
|
|
|||
| ## | |||
| ## We want to use &GAP's function call syntax also for certain Julia objects | |||
| ## that are <E>not</E> functions, for example for types such as <C>fmpz</C>. | |||
| ## that are <E>not</E> functions, for example <C>ZZ</C>. | |||
There was a problem hiding this comment.
or we could just reference a base type?
Suggested change
| ## that are <E>not</E> functions, for example <C>ZZ</C>. | |
| ## that are <E>not</E> functions, for example for types such as <C>String</C>. | |
fingolfin
reviewed
Feb 23, 2023
| (true, 1.4142135623730951) | ||
|
|
||
| julia> GAP.call_with_catch( sqrt, -2 ) | ||
| (false, "DomainError(-2.0, \\"sqrt will only return a complex result if called with a complex argument. Try sqrt(Complex(x)).\\")") |
There was a problem hiding this comment.
It seems there is a similar problem (changes in the error in Julia nightly) inside pkg/JuliaInterface/tst/utils.tst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.