Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building digraphs and other packages #854

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

fingolfin
Copy link
Member

This should fix #851 (cc @zickgraf).

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #854 (b9a1da9) into master (0ec5deb) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files          49       49           
  Lines        3677     3677           
=======================================
  Hits         3008     3008           
  Misses        669      669           
Impacted Files Coverage Δ
src/setup.jl 80.34% <100.00%> (ø)

@zickgraf
Copy link

zickgraf commented Feb 3, 2023

I can confirm that with this PR I can install and load Digraphs without an error 🎉 Thanks a lot!

@fingolfin fingolfin merged commit 947587a into oscar-system:master Feb 3, 2023
@fingolfin fingolfin deleted the mh/fix-pkg-building branch February 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "undefined symbol" when trying to load Digraphs after installation with GAP.Packages.install
2 participants