Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gap's --packagedirs instead of symlinking in gaproot #1095

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Dec 18, 2024

Resolves #1092.

This needs gap-system/gap#5873 to be available in the used GAP. Thus, I only expect the CI with GAP / julia * / GAP master jobs to succeed.

@lgoettgens lgoettgens changed the title Proof-of-cooncept: Use gap's --packagedirs instead of symlinking in gaproot Proof-of-cooncept: Use gap's --packagedirs instead of symlinking in gaproot Dec 18, 2024
@lgoettgens lgoettgens changed the title Proof-of-cooncept: Use gap's --packagedirs instead of symlinking in gaproot Proof-of-concept: Use gap's --packagedirs instead of symlinking in gaproot Dec 18, 2024
@lgoettgens lgoettgens force-pushed the lg/PackageDirectories branch from d0b6641 to ade6cba Compare December 18, 2024 14:21
@lgoettgens lgoettgens added the DO NOT MERGE DO NOT MERGE label Dec 18, 2024
@lgoettgens lgoettgens requested a review from fingolfin December 18, 2024 14:31
@lgoettgens lgoettgens closed this Jan 4, 2025
@lgoettgens lgoettgens reopened this Jan 4, 2025
@lgoettgens lgoettgens closed this Jan 6, 2025
@lgoettgens lgoettgens reopened this Jan 6, 2025
@lgoettgens lgoettgens force-pushed the lg/PackageDirectories branch from a1faa96 to 62fb67e Compare January 6, 2025 16:01
@lgoettgens lgoettgens changed the title Proof-of-concept: Use gap's --packagedirs instead of symlinking in gaproot Use gap's --packagedirs instead of symlinking in gaproot Jan 6, 2025
@fingolfin
Copy link
Member

This looks good, clean and simple.

But unfortunately it will have to wait some time, until --packagedirs arrives in our GAP... Normally this would have to wait for GAP 4.15, i.e. a couple months... but I guess we could also patch our GAP to already contain this code... But maybe we should first get 0.13.0 released.

@lgoettgens lgoettgens removed the DO NOT MERGE DO NOT MERGE label Jan 7, 2025
@lgoettgens
Copy link
Member Author

Do we want to proceed with this before GAP 4.15 gets released, i.e. with patching gap-system/gap#5873 into GAP_lib_jll? If yes, I can prepare the yggdrasil PR for that.

@fingolfin
Copy link
Member

@lgoettgens yes please

I also would like to release GAP 4.14.1 in the next 2-3 weeks (CC @ThomasBreuer) to get some GAP library & package bug fixes (but that's orthogonal)

@lgoettgens lgoettgens force-pushed the lg/PackageDirectories branch from 62fb67e to b4b8133 Compare January 21, 2025 09:53
@lgoettgens lgoettgens closed this Jan 21, 2025
@lgoettgens lgoettgens reopened this Jan 21, 2025
@lgoettgens lgoettgens closed this Jan 21, 2025
@lgoettgens lgoettgens reopened this Jan 21, 2025
@lgoettgens lgoettgens closed this Jan 21, 2025
@lgoettgens lgoettgens reopened this Jan 21, 2025
Project.toml Outdated Show resolved Hide resolved
@lgoettgens lgoettgens force-pushed the lg/PackageDirectories branch from eff50a8 to 18e3467 Compare January 21, 2025 15:13
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (fe2abef) to head (c990b2b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   74.66%   74.50%   -0.16%     
==========================================
  Files          55       55              
  Lines        4713     4711       -2     
==========================================
- Hits         3519     3510       -9     
- Misses       1194     1201       +7     
Files with missing lines Coverage Δ
src/GAP.jl 87.09% <100.00%> (+0.31%) ⬆️
src/setup.jl 78.18% <ø> (-7.04%) ⬇️

@lgoettgens lgoettgens force-pushed the lg/PackageDirectories branch from 18e3467 to c990b2b Compare January 21, 2025 15:17
@lgoettgens
Copy link
Member Author

I had to add a patch containing gap-system/gap#5873 here as well, so we can patch gap stable-4.14 in the CI with GAP CI job.

@lgoettgens lgoettgens marked this pull request as ready for review January 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExtendPackageDirectories to GAP so we can get rid of mutable GAP root
2 participants