-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gap's --packagedirs
instead of symlinking in gaproot
#1095
base: master
Are you sure you want to change the base?
Conversation
--packagedirs
instead of symlinking in gaproot
--packagedirs
instead of symlinking in gaproot--packagedirs
instead of symlinking in gaproot
d0b6641
to
ade6cba
Compare
a1faa96
to
62fb67e
Compare
--packagedirs
instead of symlinking in gaproot--packagedirs
instead of symlinking in gaproot
This looks good, clean and simple. But unfortunately it will have to wait some time, until |
Do we want to proceed with this before GAP 4.15 gets released, i.e. with patching gap-system/gap#5873 into GAP_lib_jll? If yes, I can prepare the yggdrasil PR for that. |
@lgoettgens yes please I also would like to release GAP 4.14.1 in the next 2-3 weeks (CC @ThomasBreuer) to get some GAP library & package bug fixes (but that's orthogonal) |
62fb67e
to
b4b8133
Compare
eff50a8
to
18e3467
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
- Coverage 74.66% 74.50% -0.16%
==========================================
Files 55 55
Lines 4713 4711 -2
==========================================
- Hits 3519 3510 -9
- Misses 1194 1201 +7
|
18e3467
to
c990b2b
Compare
I had to add a patch containing gap-system/gap#5873 here as well, so we can patch gap |
Resolves #1092.
This needs gap-system/gap#5873 to be available in the used GAP. Thus, I only expect the
CI with GAP / julia * / GAP master
jobs to succeed.