Add composite action to create upstream tag #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release_bot.py contains several steps, which were previously part of our release script in osbuild/maintainer-tools. The script here is much shorter though. Things that were dropped were the sanity checks, because we can presume that the git repository at hand is sane, that the git remote is well configured etc. Furthermore all interactivity of the original script was removed. Even though I had recently added a --no-interactive mode to the original script, I just felt this would make the code harder to read. The rationale for making this a composite action instead of a standalone repository was that this way each component can define it's own automated schedule and that there would be some representation in the GitHub Actions for the component of the tag being created.
5 tasks
ondrejbudai
reviewed
Mar 21, 2022
Co-authored-by: Ondřej Budai <obudai@redhat.com>
ondrejbudai
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release_bot.py contains several steps, which were previously part of
our release script in osbuild/maintainer-tools. The script here is much
shorter though.
Things that were dropped were the sanity checks, because we can presume
that the git repository at hand is sane, that the git remote is well
configured etc.
Furthermore all interactivity of the original script was removed. Even
though I had recently added a --no-interactive mode to the original
script, I just felt this would make the code harder to read.
The rationale for making this a composite action instead of a standalone
repository was that this way each component can define it's own
automated schedule and that there would be some representation in the
GitHub Actions for the component of the tag being created.
I'm happy to drop the Contributors list and the date/location line. Those felt more
meaningful when it was still a human doing the release.