Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external: Support multiple external paths #266

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Oct 2, 2024

Split the OTK_EXTERNAL_PATH on : like normal shell path handling in order to enable adding multiple external paths via the environment. Also adds a test for the new behavior.

Split the OTK_EXTERNAL_PATH on `:` like normal shell path handling in
order to enable adding multiple external paths via the environment.
Also adds a test for the new behavior.
@bcl bcl requested a review from mvo5 October 2, 2024 16:43
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think we discussed wanting to have this previously as well in either #185 or #94.

@supakeen supakeen added this pull request to the merge queue Oct 2, 2024
Merged via the queue into osbuild:main with commit 73196b0 Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants