external: add new get-dnf4-package-info external
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
external-get-version
branch
from
d6a8f87
to
6d83c04
Compare
supakeen
previously approved these changes
Sep 26, 2024
achilleas-k
previously approved these changes
Sep 26, 2024
This commit updates the generated mock meta-data from the `gen_depsolve_dnf4` to follow the `gen_manifests` updates from the images library, most notably: osbuild/images#937 osbuild/images#943
This commit adds a new `get-dnf4-package-info` external that can
be used to extract details about a dnf4 resolved package.
The main use-case is the kernel package where we need some details
like the version number to put into the grub stage. With this
commit we can do something like:
```yaml
kernel:
package:
otk.external.osbuild-get-dnf4-package-info:
packageset: ${packages.os}
packagename: ${modifications.kernel_package_name}
```
This commit uses the new `osbuild-get-dnf4-package-info` for the real otk examples.
mvo5
force-pushed
the
external-get-version
branch
from
6d83c04
to
9f127de
Compare
supakeen
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external: add new
get-dnf4-package-infoexternalThis commit adds a new
get-dnf4-package-infoexternal that canbe used to extract details about a dnf4 resolved package.
The main use-case is the kernel package where we need some details
like the version number to put into the grub stage. With this
commit we can do something like:
example: use new
osbuild-get-dnf4-package-infoexternalThis commit uses the new
osbuild-get-dnf4-package-infofor thereal otk examples.
external: update mock data in gen_depsolve_dnf4 to follow
images
This commit updates the generated mock meta-data from the
gen_depsolve_dnf4to follow thegen_manifestsupdates from theimages library, most notably:
osbuild/images#937
osbuild/images#943
Alternative idea to #205 which avoids the issues that we need nested ${packages.${kerel.pkgname}} declarations.