test: tweak gen-images() to be smarter about the UUID hacks #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be a lot of work to instead iterate through |
mvo5
force-pushed
the
hacky-gen-images-uuid-smartz
branch
2 times, most recently
from
3b48164
to
5dc0d5f
Compare
mvo5
force-pushed
the
hacky-gen-images-uuid-smartz
branch
from
5dc0d5f
to
bea0b83
Compare
|
We will also need to revert 48c9889 here if/after #209 gets merged (see #209 (review)) |
achilleas-k
approved these changes
Sep 23, 2024
achilleas-k
requested changes
Sep 23, 2024
mvo5
force-pushed
the
hacky-gen-images-uuid-smartz
branch
from
bea0b83
to
1d88c34
Compare
mvo5
force-pushed
the
hacky-gen-images-uuid-smartz
branch
from
1d88c34
to
d0f4edf
Compare
supakeen
force-pushed
the
hacky-gen-images-uuid-smartz
branch
from
d0f4edf
to
228070e
Compare
supakeen
previously approved these changes
Sep 26, 2024
This reverts commit b87cba3.
This commit tweaks the gen-images-ref to be slightly smarter about how to handle UUIDs. Instead of the extremly naive table of uuids generated by "images" and "gen-partition-table" it now tries to figure out the UUID from images via the "mkfs" stage of the manifest. This is also a bit (f)ugly but avoids some busywork. Hopefully we find a better way but this should give us some time.
The new `gen-images` will create predictable UUIDs now but the `centos_9-aarch64-qcow2-empty` reference was build without it so this commit re-generates it.
achilleas-k
previously approved these changes
Sep 26, 2024
|
Test manifests need updating |
The new `gen-images` will create predictable UUIDs now but the `centos_9-aarch64-ami-empty` reference was build without it so this commit re-generates it.
mvo5
force-pushed
the
hacky-gen-images-uuid-smartz
branch
from
228070e
to
9a64af4
Compare
supakeen
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks the gen-images-ref to be slightly smarter
about how to handle UUIDs. Instead of the extremly naive table
of uuids generated by "images" and "gen-partition-table" it now
tries to figure out the UUID from images via the "mkfs" stage
of the manifest. This is also a bit (f)ugly but avoids some
busywork.
Hopefully we find a better way but this should give us some
time.