examples,tests: add new test_against_images_ref.py test
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
previously approved these changes
Sep 4, 2024
Thank you! Yeah, it also looks like "yaml.dump()" is not generating yamllint clean yaml :( [edit: https://github.com/yaml/pyyaml/issues/234#issuecomment-765894586 is a workaround but we still run into yamllint errors because the lines are too long] |
This commit adds the infrastructure to test that a manifest generated by the `images` library is identical to the equivalent version generated via otk. As a first step it adds the centos-9-x86_64-qcow2 manifest.
This commit adds otk manifests based on the "images" library reference images.
This commit adds otk manifests based on the "images" library reference images.
mvo5
force-pushed
the
have-images-reference-test
branch
from
a45d665
to
a84b65c
Compare
mvo5
force-pushed
the
have-images-reference-test
branch
from
a84b65c
to
33a616e
Compare
supakeen
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test that uses the
imageslibrary to generate reference manifests and then compares the output of an otk run against the reference image. This allows us to refactor theotkimages and always be confident that the result matches what "images" produces.It also converts all the examples to be just "verbatim" versions of the images library result so that it can be a useful starting point to refactor them.
Note that currently the reference manifests are part of the repository for convenience. It would be nicer to generate them on the fly but that is hard(er), see the comments in the code.
Note also that we most likely will have to do something about the "{boot,root}_fs_uuid" in the reference images as they will not match with the ones generated by
otk-gen-partition-tableas the calls intorandare in a different order yielding predictable but different result between the two. We can cross this bridge when we reach it though and it's fairly simple (or exclude at the diff level).When we add the
dnfjsonexternal we will need to teach it to generate fake urls/shas just likegen-manifestsso that we can compare the results of a real run.The next steps should be to extract the common pieces into a nice structure (i.e. build #169 on top of this one) and integrate the externals (i.e. start with partition, c.f. #186)
[clean split out from https://github.com//pull/186]