workflow: generate PR comments when non-required tests fail and let the action itself succeed (part 1) #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
non-required-test-comments
branch
from
3f880c7
to
b8517f5
Compare
The purpose of this new workflow is to run when certain actions are allowed to cause errors without failing but PR authors and reviewers should be notified of issues. The goal is, instead of having actions that are allowed to fail and are marked as not required, the actions themselves will succeed but will communicate an error message through a shared artifact that this action can read and use to post a comment on the PR. The action is run as a 'workflow_run' to have access to secrets (Schutzbot's access token). The action is not finalised in this commit.
achilleas-k
force-pushed
the
non-required-test-comments
branch
from
b8517f5
to
3d57c30
Compare
achilleas-k
added
the
github_actions
mvo5
approved these changes
Oct 11, 2024
achilleas-k
changed the title
achilleas-k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this new workflow is to run when certain actions are allowed to cause errors without failing but PR authors and reviewers should be notified of issues. The goal is, instead of having actions that are allowed to fail and are marked as not required, the actions themselves will succeed but will communicate an error message through a shared artifact that this action can read and use to post a comment on the PR.
The action is run as a 'workflow_run' to have access to secrets (Schutzbot's access token).
The action is not finalised in this commit.
The plan is to merge this into
mainas is, so that GitHub will pick up the new workflow and we can iterate on the implementation in a follow-up PR, since GitHub will not run actions defined in workflows that are not part of the main branch but will run modified versions of a pre-existing action.