Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otk-gen-partition-table: add support for ppc64/s390x partition tables #963

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Oct 1, 2024

This commit adds support for "raw" partitions without a "payload",
i.e. no filesystem or LVM volume or similar. This is used for the
PPC64/s390x partition table that looks like this:

otk.define:
  filesystem:
    modifications:
    # empty
    otk.external.otk-gen-partition-table:
      modifications:
        ${filesystem.modifications}
      properties:
        type: dos
        default_size: "10 GiB"
        uuid: "0x14fc63d2"
      partitions:
        - name: ppc-boot
          bootable: true
          size: "4 MiB"
          part_uuid: ""
          part_type: "41"
        - name: boot
          mountpoint: /boot
          label: boot
          size: "1 GiB"
          type: "xfs"
          fs_mntops: defaults
          part_uuid: ""
        - name: root
          mountpoint: /
          type: "xfs"
          size: "2 GiB"
          fs_mntops: defaults
          part_uuid: ""

Thanks to Florian Schüller for the initial implementation/research
here, see also #952


otk-gen-partition-table: add bootable flag support

This commit adds support to mark partitions as bootable from
an otk-gen-partition-table input. E.g.:

{
...
  "partitions": [
    {
...
      "bootable": true,
...
    },

@schuellerf schuellerf changed the title otk-gen-partition-table: add supprot for ppc64/s390x partition tables otk-gen-partition-table: add support for ppc64/s390x partition tables Oct 1, 2024
mvo5 and others added 2 commits October 4, 2024 15:21
This commit adds support to mark partitions as bootable from
an `otk-gen-partition-table` input. E.g.:
```yaml
{
...
  "partitions": [
    {
...
      "bootable": true,
...
    },
```
This commit adds support for "raw" partitions without a "payload",
i.e. no filesystem or LVM volume or similar. This is used for the
PPC64/s390x partition table that looks like this:
```
otk.define:
  filesystem:
    modifications:
    # empty
    otk.external.otk-gen-partition-table:
      modifications:
        ${filesystem.modifications}
      properties:
        type: dos
        default_size: "10 GiB"
        uuid: "0x14fc63d2"
      partitions:
        - name: ppc-boot
          bootable: true
          size: "4 MiB"
          part_uuid: ""
          part_type: "41"
        - name: boot
          mountpoint: /boot
          label: boot
          size: "1 GiB"
          type: "xfs"
          fs_mntops: defaults
          part_uuid: ""
        - name: root
          mountpoint: /
          type: "xfs"
          size: "2 GiB"
          fs_mntops: defaults
          part_uuid: ""
```
Thanks to Florian Schüller for the initial implementation/research
here.

Co-authored-by: Florian Schüller <florian.schueller@redhat.com>
@supakeen supakeen added this pull request to the merge queue Oct 4, 2024
Merged via the queue into osbuild:main with commit 232cfd1 Oct 4, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants