Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: drop -v from go test #948

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Sep 24, 2024

This commit removes -v from go test. The test output is very long (17k lines according to GH) and most is just:

...
--- PASS: TestRPMDeduplication (0.00s)
...

but when trying to find a failing test (like in PR#945) scrolling through to find the actual failing one becomes a bit cumbersome.

So this commit drops -v.

This commit removes `-v` from `go test`. The test output is very
long (17k lines according to GH) and most is just:
```
...
--- PASS: TestRPMDeduplication (0.00s)
...
```
but when trying to find a failing test (like in PR#945) scrolling
through to find the actual failing one becomes a bit cumbersome.

So this commit drops `-v`.
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'd swear that without -v there wasn't enough context to debug random errors -- but having just tested that here locally I am still seeing decent output.
ACK!

@supakeen supakeen added this pull request to the merge queue Sep 25, 2024
Merged via the queue into osbuild:main with commit 7e0acde Sep 25, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants