Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anaconda: enable SELinux for live-installer #897

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Sep 3, 2024

The live installer build has been installing non-enforcing systems. This is due to a leftover from the image installer setting the system to permissive.

Make it so we apply the contexts and don't write a permissive config for the live installer.

Closes #460 which has been flying under my radar for entirely too long.

The live installer build has been installing non-enforcing systems. This
is due to a leftover from the image installer setting the system to
permissive.

Make it so we apply the contexts and don't write a permissive config for
the live installer.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
The previous commit introduced SElinux to the live installer. This
commit brings the pipeline more in line with the os pipeline, SElinux is
now a property on the pipeline set in the image.

It is hardcoded to be set to targeted for live installers and is
considered a programming error to be set for non-live installers.

Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
@supakeen supakeen requested a review from thozza September 4, 2024 06:42
@supakeen
Copy link
Member Author

supakeen commented Sep 4, 2024

Note that I could be convinced to move this to the same paradigm with NoSELinux, it might make sense for the live installer to be able to toggle it off on a higher level? It'd still be an error for the non-live installers.

The non-live installers could be done as a follow up but we have the 'problem' there that we need to ensure that the toggle makes sense and goes to the right place as the anaconda-tree is not the tree being installed to system so we'd have two SElinux policies there.

Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. This looks good enough for me 🙂

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM!

@achilleas-k achilleas-k added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@achilleas-k
Copy link
Member

The CentOS Stream 10 unit tests are failing because dnf-plugins-core seems to have disappeared.

@nullr0ute
Copy link
Contributor

The CentOS Stream 10 unit tests are failing because dnf-plugins-core seems to have disappeared.

there's dnf5-plugins that replace "core/extras" but they've not done proper provides/obsoleted etc. I think core needs to come back, I am going to file a bug on this because it bit me the other day too in a different usecase, will reference the bug

@nullr0ute
Copy link
Contributor

@achilleas-k
Copy link
Member

The CentOS Stream 10 unit tests are failing because dnf-plugins-core seems to have disappeared.

there's dnf5-plugins that replace "core/extras" but they've not done proper provides/obsoleted etc. I think core needs to come back, I am going to file a bug on this because it bit me the other day too in a different usecase, will reference the bug

Thanks! Though, doing a quick check with the centos:stream10-development container (which we use for testing), I don't see anything for dnf search plugins. I found this though: https://issues.redhat.com/browse/CPE-2396

@supakeen supakeen added this pull request to the merge queue Sep 4, 2024
Merged via the queue into osbuild:main with commit 523d80f Sep 4, 2024
18 checks passed
@supakeen supakeen deleted the live-installer-selinux branch September 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SELinux is in permissive mode for live-installer
4 participants