cmd/otk-*: do basic input validation to avoid crashing too easily #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
reviewed
Sep 3, 2024
I don't see a downside in merging it now, we can expand |
supakeen
approved these changes
Sep 3, 2024
achilleas-k
approved these changes
Sep 6, 2024
This commit is a lesson from osbuild/otk#186 as it is right now extremly easy to crash the otk disk externals with bad inputs. This commit adds basic input validation, it's probably a good idea to also go deeper into the library and make it less trusting about pointers but that is (slightly) orthogonal.
bcl
force-pushed
the
crash-less-in-otk-externals
branch
from
da422b5
to
b617d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a lesson from osbuild/otk#186 as it is right now extremly easy to crash the otk disk externals with bad inputs.
This commit adds basic input validation, it's probably a good idea to also go deeper into the library and make it less trusting about pointers but that is (slightly) orthogonal.