manifest: extract tomlPkgsFor() helper and fix ordering #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
commented
Aug 16, 2024
achilleas-k
requested changes
Aug 16, 2024
|
Let's bump the osbuild commit ID to |
mvo5
force-pushed
the
clarify-toml-in-rh10
branch
from
071d77c
to
1747f6d
Compare
mvo5
force-pushed
the
clarify-toml-in-rh10
branch
2 times, most recently
from
15baaa3
to
59b2226
Compare
achilleas-k
approved these changes
Aug 20, 2024
mvo5
commented
Aug 20, 2024
mvo5
force-pushed
the
clarify-toml-in-rh10
branch
from
59b2226
to
23bba03
Compare
The code is a bit too terse for my liking right now and does just have an empty `case DISTO_EL10` - so this commit adds a comment.
The current code will install python3-toml on fedora and also on rhel11 (once it comes out) because that is the default for unhandled distros. This commit makes the various toml libs for each distro more explicit, see also osbuild/osbuild#1851
bcl
force-pushed
the
clarify-toml-in-rh10
branch
from
23bba03
to
039febe
Compare
achilleas-k
approved these changes
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
supakeen
reviewed
Oct 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Some job on the merge queue got stuck, didn't even start, just appears in a paused/waiting state. Weird! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code will install python3-toml on fedora and also
on rhel11 (once it comes out) because that is the default for
unhandled distros. With
tomlibin the stdlib this is nolonger needed.
[draft as it has no test(s)]