Run unit tests on Fedora 40 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
f40-unit-tests
branch
from
b862839
to
d783be9
Compare
Fedora 40 has been released and the fedora:latest container changed to F40, breaking our unit tests because the 'setup-osbuild-repo' wasn't setting up a pinned repository for osbuild on F40. Let's run unit tests on both F39 and F40.
Pin the osbuild commit ID for Fedora 40 unit tests. We don't use F40 in gitlab CI so we don't need to worry about rpm repos for now.
achilleas-k
force-pushed
the
f40-unit-tests
branch
from
d783be9
to
0dacaec
Compare
|
I'll keep the Fedora 40 unit tests as non-required for now until I have time to look into the failure, but I think we should merge this to unblock other PRs that are running on F40 now because of the |
|
kingsleyzissou
previously approved these changes
Apr 25, 2024
thozza
previously approved these changes
Apr 25, 2024
This wasn't an issue until now. Dnf5 however validates the string and would return an error.
achilleas-k
force-pushed
the
f40-unit-tests
branch
from
e529508
to
7fa52cf
Compare
kingsleyzissou
approved these changes
Apr 25, 2024
|
Merging this to unblock other PRs and we can make F40 required as soon as we fix all the unit tests. |
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 40 has been released and the fedora:latest container changed to
F40, breaking our unit tests because the 'setup-osbuild-repo' wasn't
setting up a pinned repository for osbuild on F40.
Let's run unit tests on both F39 and F40.