Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora/live-installer: ppc64le #63

Closed

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Jul 27, 2023

We've recently gained PPC64LE workers for koji, let's build the live installer.

Note: broken, need to figure out build and boot packages.

  • Enables repositories for PPC64LE in fedora.
  • Adjusts testcases to expect PPC64LE.
  • Adds a single image type to the PPC64LE architecture (live-installer).

@supakeen supakeen force-pushed the enable-ppc-for-the-live-installer branch from bc23d87 to cbd8230 Compare July 27, 2023 17:09
We've recently gained PPC64LE workers for koji, let's build the live
installer.
@supakeen supakeen force-pushed the enable-ppc-for-the-live-installer branch from cbd8230 to e04760d Compare July 27, 2023 17:16
@supakeen supakeen changed the title fedora/live-installer: ppc64le support fedora/live-installer: ppc64le Jul 27, 2023
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks sensible, I added a few comments but nothing serious...

&platform.PPC64LE{
BIOS: true,
},
liveInstallerImgType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should enable the ppc64le architecture also for other image types, mainly the qcow2 type. The COPR team has been asking for this for ages... 🤔

@@ -252,6 +252,7 @@ func TestImageType_BuildPackages(t *testing.T) {
buildPackages := map[string][]string{
"x86_64": x8664BuildPackages,
"aarch64": aarch64BuildPackages,
"ppc64le": []string{},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this is redundant, since the map will return the empty type for non-existent keys.

@@ -378,7 +378,8 @@ func anacondaPackageSet(t *imageType) rpmmd.PackageSet {
"dmidecode",
},
})

case platform.ARCH_PPC64LE.String():
// XXX what goes here for PPC64LE?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 something to figure out...

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 8, 2023
@thozza thozza removed the Stale label Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 9, 2023
@thozza thozza removed the Stale label Oct 9, 2023
@thozza
Copy link
Member

thozza commented Oct 11, 2023

Just FYI, I added ppc64le and s390x support for qcow2 and container in #198

Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 11, 2023
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants