-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fedora/live-installer: ppc64le #63
Conversation
bc23d87
to
cbd8230
Compare
We've recently gained PPC64LE workers for koji, let's build the live installer.
cbd8230
to
e04760d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks sensible, I added a few comments but nothing serious...
&platform.PPC64LE{ | ||
BIOS: true, | ||
}, | ||
liveInstallerImgType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should enable the ppc64le architecture also for other image types, mainly the qcow2
type. The COPR team has been asking for this for ages... 🤔
@@ -252,6 +252,7 @@ func TestImageType_BuildPackages(t *testing.T) { | |||
buildPackages := map[string][]string{ | |||
"x86_64": x8664BuildPackages, | |||
"aarch64": aarch64BuildPackages, | |||
"ppc64le": []string{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: this is redundant, since the map will return the empty type for non-existent keys.
@@ -378,7 +378,8 @@ func anacondaPackageSet(t *imageType) rpmmd.PackageSet { | |||
"dmidecode", | |||
}, | |||
}) | |||
|
|||
case platform.ARCH_PPC64LE.String(): | |||
// XXX what goes here for PPC64LE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 something to figure out...
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Just FYI, I added ppc64le and s390x support for qcow2 and container in #198 |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 30+7 days with no activity. |
We've recently gained PPC64LE workers for koji, let's build the live installer.
Note: broken, need to figure out build and boot packages.
live-installer
).