Add ReadOSReleaseFromTree (HMS-3783) #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method supports reading os-release from an arbitrary tree, and it also correctly handles multiple os-release locations (see os-release(5)). It's public so we can reuse it in multiple places.
The function now works even without /etc/os-release (which is rare but possible). The function now also no longer panics if ID or VERSION_ID aren't set. Some tests were added to cover everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function
distro.ReadOSReleaseFromTreethat can read an os-release(5) from a given tree. This is needed for osbuild/bootc-image-builder#338