Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified-installer/fedora: extend rootlv size #169

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

pcdubs
Copy link

@pcdubs pcdubs commented Sep 21, 2023

This PR fixes #3529 , and extends the iotSimplifiedInstallerPartitionTables rootlv to 8GiB.

Signed-off-by: Paul Whalen <pwhalen@fedoraproject.org>
@achilleas-k
Copy link
Member

achilleas-k commented Sep 21, 2023

This shouldn't be necessary. The coreos-installer should be growing the root filesystem after installation to fill the disk and the raw image file in the simplified installer is already set to 10 GiB:

defaultSize: 10 * common.GibiByte,

I did a quick test locally and saw that the growfs stage of the installation is failing with /dev/sda3 is in use by /dev/dm-0: found busy partitions

image

We should figure out what's going on there instead.

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Request changes until we figure out what's wrong.

@pcdubs
Copy link
Author

pcdubs commented Sep 21, 2023

This shouldn't be necessary. The coreos-installer should be growing the root filesystem after installation to fill the disk and the raw image file in the simplified installer is already set to 10 GiB:

This is to closer match the sizing in edgeBasePartitionTables. Currently coreos-installer-growfs grows the partition, but not the root filesystem. I believe this is to leave storage for other services, similar to Fedora Server.

@achilleas-k
Copy link
Member

This shouldn't be necessary. The coreos-installer should be growing the root filesystem after installation to fill the disk and the raw image file in the simplified installer is already set to 10 GiB:

This is to closer match the sizing in edgeBasePartitionTables. Currently coreos-installer-growfs grows the partition, but not the root filesystem. I believe this is to leave storage for other services, similar to Fedora Server.

We also keep it small because it's straightforward to grow after deployment if needed, whereas shrinking isn't.

All that said, if this is how we (well, you) want to define the image, then let's do it. I'd still like to look into the growfs failure I saw above, but that can be done separately.

@achilleas-k achilleas-k added this pull request to the merge queue Sep 22, 2023
Merged via the queue into osbuild:main with commit cf1243b Sep 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iot-simplified-installer /sysroot lv size should be 9G on fedora 38
2 participants